Skip to content

Show last used bagde only if there are more than one login method#5947

Merged
kzuraw merged 2 commits intomainfrom
eng-821-last-used-only-method-main
Oct 7, 2025
Merged

Show last used bagde only if there are more than one login method#5947
kzuraw merged 2 commits intomainfrom
eng-821-last-used-only-method-main

Conversation

@kzuraw
Copy link
Contributor

@kzuraw kzuraw commented Oct 7, 2025

Scope of the change

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings October 7, 2025 07:10
@kzuraw kzuraw requested a review from a team as a code owner October 7, 2025 07:10
@kzuraw kzuraw added the skip changeset Use if your changes doesn't need entry in changelog label Oct 7, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d3efb86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Preview Oct 7, 2025 7:10am

Copilot AI reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds conditional logic so the last login indicator for password is only shown when additional (external) authentication methods exist.

  • Introduces a boolean variable to encapsulate the display condition
  • Replaces inline condition with the new variable for clarity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.06%. Comparing base (79ed00b) to head (d3efb86).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #5947    +/-   ##
========================================
  Coverage   40.06%   40.06%            
========================================
  Files        2473     2473            
  Lines       40228    40229     +1     
  Branches     8853     9185   +332     
========================================
+ Hits        16118    16119     +1     
  Misses      24083    24083            
  Partials       27       27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kzuraw kzuraw merged commit 7458fc7 into main Oct 7, 2025
16 checks passed
@kzuraw kzuraw deleted the eng-821-last-used-only-method-main branch October 7, 2025 09:42
kzuraw added a commit that referenced this pull request Oct 7, 2025
@kzuraw
Show last used bagde only if there are more than one login method (#5947
9c9ceae 
)
@kzuraw kzuraw mentioned this pull request Oct 7, 2025
Merged
2 tasks
kzuraw added a commit that referenced this pull request Oct 7, 2025
@kzuraw
[3.21] Show last used bagde only if there are more than one login met…
ab0fbd2 
…hod (#5948)

* Show last used bagde only if there are more than one login method (#5947)

* Add changeset

* fix changset wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@witoszekdev witoszekdev witoszekdev approved these changes

@lkostrowski lkostrowski Awaiting requested review from lkostrowski lkostrowski is a code owner automatically assigned from saleor/js

Assignees

No one assigned

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kzuraw @witoszekdev